-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cbits/directory.c file #50
Comments
I posted about this in the past but got no responses or complaints. I think they can be replaced with hsc2hs. Would removing them require bumping the major version? |
IMHO even hsc2hs is overkill here, just plain CapiFFI would probably suffice |
Wouldn't that require dropping support for GHC 7.4? |
No. Evidence: See also https://ghc.haskell.org/trac/ghc/wiki/LanguagePragmaHistory |
Oh oops, I saw it in the release notes for 7.6 and thought it was introduced then. |
@Rufflewind yeah, that's been a cause of common confusion. There's quite a few who came to believe that CapiFFI excludes GHC 7.4 |
Based on a few Google searches, I don't think anyone uses the header or any of its functions, so I'll remove them and bump only the minor version. (I also forgot that I had already removed the dependence on the C bits in the library code, so all I have to do now is to actually delete them.) |
See also: 7d36863 Fixes haskell#50.
See also: 7d36863 Fixes haskell#50.
or more generally rethink how to handle the cbits in future, they seem kinda redundant by now
this includes figuring out if there's anyone depending on the
.h
files that may break...The text was updated successfully, but these errors were encountered: