Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-source must not have c++ source files in it #43

Closed
Kleidukos opened this issue Sep 25, 2023 · 8 comments · Fixed by #44
Closed

c-source must not have c++ source files in it #43

Kleidukos opened this issue Sep 25, 2023 · 8 comments · Fixed by #44

Comments

@Kleidukos
Copy link
Member

c-source must not have c++ source files in it, these should go in cxx-sources.

see haskell/cabal#9200

Kleidukos added a commit to Kleidukos/double-conversion that referenced this issue Sep 25, 2023
@Mikolaj
Copy link
Member

Mikolaj commented Sep 25, 2023

[Edit: a misplaced comment, apologies]

@sternenseemann
Copy link

I think a lot of downstream people will still run into this until a release with this fix is uploaded to hackage.

@Kleidukos
Copy link
Member Author

@Haskell-mouse Do you think you could make a revision? :)

@Haskell-mouse
Copy link
Collaborator

@Haskell-mouse Do you think you could make a revision? :)

@Kleidukos Yes, thanks for the remind. I am going to do this next week.

@sternenseemann
Copy link

@Haskell-mouse Do you think you could make a revision? :)

This needs a new release, I believe. As far as I know Hackage forbids changing build related stanzas in a cabal file.

@Kleidukos
Copy link
Member Author

Ah, well-spotted! I am not a big revisions user. :)

@andreasabel
Copy link
Member

@Haskell-mouse : Friendly reminder that a release is needed.

Maybe it would also good to add a backup maintainer to the Hackage uploaders for this package, e.g. @Kleidukos .

@Kleidukos
Copy link
Member Author

It would probably be better to introduce people who have knowledge and understanding of the library's domain, I know I don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants