Restore identifiers missing from hi file #741
Conversation
There was a problem hiding this comment.
Awesome, thank you!
Looks like some compat. changes are needed for GHC <8.8. I would suggest moving fixDetailsForTH to Development.IDE.GHC.Compat and use CPP to allow for multiple implementations. You can choose to use return for the <8.8 implementation if it turns out to be too hard to fix.
|
I am sorry, that I have not looked into this further. I realized that this only one and not the TH issues I have. I will address the fixes, when I find the time. |
|
@maralorn which is the TH issue you have? |
|
Well that's what I reported at #614. I have a failing testcase linked there. |
|
@maralorn can you add your failing test case here with "known broken"? |
|
(I will rebase the PR when it's declared ready to merge.) |
This * fixes a part of https://github.com/digital-asset/ghcide/issues/614 by introducing a workaround for ghc droping some bindings that we still need. * Adds a regression test for this fix * Adds a known broken test for the remaining part of the issue
|
All checks green. \o/ |
|
Thanks! |
This * fixes a part of https://github.com/digital-asset/ghcide/issues/614 by introducing a workaround for ghc droping some bindings that we still need. * Adds a regression test for this fix * Adds a known broken test for the remaining part of the issue
This * fixes a part of https://github.com/digital-asset/ghcide/issues/614 by introducing a workaround for ghc droping some bindings that we still need. * Adds a regression test for this fix * Adds a known broken test for the remaining part of the issue
This * fixes a part of https://github.com/digital-asset/ghcide/issues/614 by introducing a workaround for ghc droping some bindings that we still need. * Adds a regression test for this fix * Adds a known broken test for the remaining part of the issue
This * fixes a part of https://github.com/digital-asset/ghcide/issues/614 by introducing a workaround for ghc droping some bindings that we still need. * Adds a regression test for this fix * Adds a known broken test for the remaining part of the issue
This fixes part of #614 by introducing a workaround for ghc droping some bindings that we still need.