Allow specifying a custom version in advance install menu #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been a little bit out of FOSS lately but I have sometime now. Let me get use to the new changes an I'll make a review asap. |
|
@dfordivam can you rebase? |
dfordivam
force-pushed
the
dn-adv-install-version
branch
from
4a17087 to
e1d4a6f
Compare
|
@hasufell rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is necessary as the user may be installing some arbitrary version using a URI, and there is no way to specify a version for that, (like the command line
ghcup install -u <uri> <version>supports.)The
GHCTargetVersionused forinstVersionis not ideal for handling installation of other tools, but since we have a single AdvanceInstall menu shared for all tools, I think its ok to use this to avoid a bigger change to the code.