Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete pattern warnings are not highlighted #96

Closed
elldritch opened this issue May 7, 2020 · 5 comments
Closed

Incomplete pattern warnings are not highlighted #96

elldritch opened this issue May 7, 2020 · 5 comments
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@elldritch
Copy link

When I compile code with an incomplete pattern using -fwarn-incomplete-patterns, I see the incomplete pattern warning in my GHC output. I do not see a corresponding highlight for the incomplete pattern in the source code. I discovered this in the VS Code extension, although this appears to also occur in the Emacs extension (so I think it's an LSP rather than extension bug).

@ndmitchell
Copy link
Collaborator

The root cause is https://github.com/digital-asset/ghcide/issues/107

I suggest this deserves an entry on the HLS FAQ, as it does keep coming up.

@alanz
Copy link
Collaborator

alanz commented May 7, 2020

Until such time as we fix it, somehow. I think via managing scheduling.

@jneira jneira added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. component: ghcide labels May 25, 2020
@jneira
Copy link
Member

jneira commented Oct 12, 2020

As commented in #96 the ghcide issue is https://github.com/haskell/ghcide/issues/107 and it was closed by haskell/ghcide#836 son only left bump the ghcide submodule to include it: #463

@jneira jneira linked a pull request Oct 12, 2020 that will close this issue
@jneira
Copy link
Member

jneira commented Oct 21, 2020

It will be close when #526 is resolved

@jneira
Copy link
Member

jneira commented Nov 9, 2020

We are using the ghcide version with the fix, @liftM feel free to reopen if it is not the case (not that you should use master until 0.5 version is not released)

@jneira jneira closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ghcide type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Development

No branches or pull requests

4 participants