Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest lsp / lsp-types / lsp-test #4166

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Upgrade to latest lsp / lsp-types / lsp-test #4166

merged 5 commits into from
Apr 30, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Apr 7, 2024

New version of lsp* has not been released yet, but I upgraded hls codebase to master version to be able to test haskell/lsp#566

UPDATE: we're not going to merge the "disable progress messages" PR in lsp repo,
but this PR can still be used because it contains all the fixes to breaking changes in lsp repo.

@soulomoon
Copy link
Collaborator

soulomoon commented Apr 28, 2024

Is the new lsp released yet, can't wait to use it since
testing the #4194 is causing a lot of 3 second wait 0 0

@jhrcek
Copy link
Collaborator Author

jhrcek commented Apr 28, 2024

It's not released yet. I just rebased this PR on master + switched to latest master commit of lsp repo.
It compiles, but there are bunch of test failures. I'll look at those over next week.

@jhrcek
Copy link
Collaborator Author

jhrcek commented Apr 29, 2024

@soulomoon @michaelpj updated to lsp master, I consider this ready to merge.
I'd suggest we release the latest changes in lsp repo to hackage and then switch this PR to use hackage releases of those packages and merge.

@michaelpj
Copy link
Collaborator

Yep, I'll do a release.

@soulomoon
Copy link
Collaborator

Great

@michaelpj
Copy link
Collaborator

Haha, I had just done that locally. You are very on it ;)

@jhrcek
Copy link
Collaborator Author

jhrcek commented Apr 30, 2024

That's what it's like having github notifications enabled and few minutes to spare between meetings 😄
Thanks for releasing new versions to hackage.

@jhrcek jhrcek marked this pull request as ready for review April 30, 2024 12:53
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for dealing with all this, much appreciated.

Copy link
Collaborator

@soulomoon soulomoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jhrcek jhrcek merged commit a339277 into master Apr 30, 2024
39 checks passed
@jhrcek jhrcek deleted the jan/upgrade-lsp branch May 11, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants