-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest lsp / lsp-types / lsp-test #4166
Conversation
b77596d
to
e60f5d4
Compare
Is the new lsp released yet, can't wait to use it since |
It's not released yet. I just rebased this PR on master + switched to latest master commit of lsp repo. |
@soulomoon @michaelpj updated to lsp master, I consider this ready to merge. |
Yep, I'll do a release. |
Great |
Haha, I had just done that locally. You are very on it ;) |
That's what it's like having github notifications enabled and few minutes to spare between meetings 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for dealing with all this, much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
New version of lsp* has not been released yet, but I upgraded hls codebase to master version to be able to test haskell/lsp#566UPDATE: we're not going to merge the "disable progress messages" PR in lsp repo,
but this PR can still be used because it contains all the fixes to breaking changes in lsp repo.