Remove dependency on uuid #576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a good idea. I think we could in fact do this even more simply. It just has to be a unique ID, so it can just be an incrementing integer! We in fact already have an id-counter that we use for request IDs, I think it sounds like we could just pull an id from that for registrations as well. |
|
I did that here: #578 |
|
Thank you! |
|
great it might help hls to use multi-repl which need cable 3.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the language server specification uses a UUID for dynamic registration of capabilities, it only has to be a unique id. This change removes the UUID dependency, replacing it with a home-grown random id generator.
The main motivation here is I'm trying to compile LSP (or rather, a program using it) to WASM. The UUID library pulls in a lot of superfluous dependencies (e.g. network-info and entropy) that don't compile with the wasm32-wasm version of GHC, hence trying to remove them.