Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StdStream(NoStream) to have standard handles closed. #13

Merged
merged 1 commit into from
Jun 14, 2015
Merged

Add StdStream(NoStream) to have standard handles closed. #13

merged 1 commit into from
Jun 14, 2015

Conversation

proger
Copy link
Contributor

@proger proger commented Dec 31, 2014

The motivation is that lots of processes behave differently when (especially) stdin is
closed vs when it's a pipe.

@hvr
Copy link
Member

hvr commented Dec 31, 2014

Oh well... adding a new constructor means a major version bump...

@hvr hvr added this to the 1.3 milestone Dec 31, 2014
@dcoutts
Copy link
Contributor

dcoutts commented Jan 11, 2015

Seems reasonable in principle. As @hvr suggests, it can probably wait a bit 'til we need a major version bump anyway.

snoyberg added a commit that referenced this pull request Jun 14, 2015
Add StdStream(NoStream) to have standard handles closed.
@snoyberg snoyberg merged commit 729656e into haskell:master Jun 14, 2015
@snoyberg
Copy link
Collaborator

Thank you!

snoyberg added a commit that referenced this pull request Jun 14, 2015
@proger
Copy link
Contributor Author

proger commented Jun 14, 2015

Yay!

@proger proger deleted the stdstream-nostream branch June 14, 2015 15:30
@snoyberg
Copy link
Collaborator

Sorry for the delay. I've been debating pushing forward a more significant
overhaul to make it easier to make changes like this in the future, but
decided such a change was not prudent. There's one more change that I'm
waiting on, and then I'll release this.

On Sun, Jun 14, 2015, 6:30 PM Vlad Ki notifications@github.com wrote:

Yay!


Reply to this email directly or view it on GitHub
#13 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants