Trac 11100 expose part of create pipe #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR works on Windows, but not on POSIX systems. |
|
Ah, I'll fix that. Thanks! |
|
@snoyberg I think the appveyor one failed because of a network failure? |
| -- | Create a pipe for interprocess communication and return a | ||
| -- @(readEnd, writeEnd)@ `FD` pair. | ||
| -- | ||
| -- @since 1.2.1.0 |
There was a problem hiding this comment.
This should actually be 1.4.2.0. Similarly, can you update the ChangeLog and the .cabal file?
Mistuke
added a commit
to Mistuke/ghc
that referenced
this pull request
Jan 25, 2016
Summary: Makes the needed changes to make RemoteGHCi work on Windows. The approach passes OS Handles areound instead of the Posix Fd as on Linux. The reason is that I could not find any real documentation about the behaviour of Windows w.r.t inheritance and Posix FDs. The implementation with Fd did not seem to be able to find the Fd in the child process. Instead I'm using the much better documented approach of passing inheriting handles. This requires a small modification to the `process` library. haskell/process#52 Test Plan: ./validate On Windows x86_64 Reviewers: simonmar, austin, hvr, thomie, bgamari, erikd Subscribers: #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D1836 GHC Trac Issues: #11100
| @@ -38,6 +38,7 @@ module System.Process.Internals ( | |||
| withFilePathException, withCEnvironment, | |||
| translate, | |||
| createPipe, | |||
| createPipeFD, | |||
There was a problem hiding this comment.
It seems common to abbreviate "file descriptor" as Fd. Given that this convention is used below perhaps it would make sense to preserve consistency here?
|
Thanks! @snoyberg, would you like to merge this or shall I? |
snoyberg
added a commit
that referenced
this pull request
Jan 26, 2016
…pipe Trac 11100 expose part of create pipe
|
I've got it, thanks Ben. I'll make a release to Hackage now. |
|
Thanks Michael! |
|
@snoyberg btw, please don't forget to PS: I see there's a lightweight tag |
|
Done Herbert, thanks for the reminder. On Tue, Jan 26, 2016 at 1:12 PM, Herbert Valerio Riedel <
|
bgamari
pushed a commit
to bgamari/ghc
that referenced
this pull request
Jan 26, 2016
Makes the needed changes to make RemoteGHCi work on Windows. The approach passes OS Handles areound instead of the Posix Fd as on Linux. The reason is that I could not find any real documentation about the behaviour of Windows w.r.t inheritance and Posix FDs. The implementation with Fd did not seem to be able to find the Fd in the child process. Instead I'm using the much better documented approach of passing inheriting handles. This requires a small modification to the `process` library. haskell/process#52 Test Plan: ./validate On Windows x86_64 Reviewers: thomie, erikd, bgamari, austin, hvr, simonmar Reviewed By: simonmar Subscribers: #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D1836 GHC Trac Issues: #11100
Mistuke
added a commit
to Mistuke/ghc
that referenced
this pull request
Jan 26, 2016
Summary: Makes the needed changes to make RemoteGHCi work on Windows. The approach passes OS Handles areound instead of the Posix Fd as on Linux. The reason is that I could not find any real documentation about the behaviour of Windows w.r.t inheritance and Posix FDs. The implementation with Fd did not seem to be able to find the Fd in the child process. Instead I'm using the much better documented approach of passing inheriting handles. This requires a small modification to the `process` library. haskell/process#52 Test Plan: ./validate On Windows x86_64 Reviewers: simonmar, austin, hvr, thomie, bgamari, erikd Subscribers: #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D1836 GHC Trac Issues: #11100
ghc-mirror
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 27, 2016
Makes the needed changes to make RemoteGHCi work on Windows. The approach passes OS Handles areound instead of the Posix Fd as on Linux. The reason is that I could not find any real documentation about the behaviour of Windows w.r.t inheritance and Posix FDs. The implementation with Fd did not seem to be able to find the Fd in the child process. Instead I'm using the much better documented approach of passing inheriting handles. This requires a small modification to the `process` library. haskell/process#52 Test Plan: ./validate On Windows x86_64 Reviewers: thomie, erikd, bgamari, simonmar, austin, hvr Reviewed By: simonmar Subscribers: #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D1836 GHC Trac Issues: #11100
ghc-mirror
pushed a commit
to ghc/ghc
that referenced
this pull request
Jan 27, 2016
Makes the needed changes to make RemoteGHCi work on Windows. The approach passes OS Handles areound instead of the Posix Fd as on Linux. The reason is that I could not find any real documentation about the behaviour of Windows w.r.t inheritance and Posix FDs. The implementation with Fd did not seem to be able to find the Fd in the child process. Instead I'm using the much better documented approach of passing inheriting handles. This requires a small modification to the `process` library. haskell/process#52 Test Plan: ./validate On Windows x86_64 Reviewers: thomie, erikd, bgamari, simonmar, austin, hvr Reviewed By: simonmar Subscribers: #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D1836 GHC Trac Issues: #11100 (cherry picked from commit 44a5d51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would like to expose a part of the
createPipeapi which just returns anPosix.FDinstead of a GHCHandle.This is for the implementation of the Windows bit of
RemoteGHCIhttps://ghc.haskell.org/trac/ghc/ticket/11100