Add groupBy for vectors

[alexkalderimis]

This adds groupBy for generic vectors, returning a list of
subvectors.

This is similar to #143, aiming to resolve #192

Some of the comments on #143 have been applied here.

Input on testing would be welcome

[Shimuuar]

Looks reasonable to me. Could you add specialized version to Data.Vector, etc and add some haddocks?

[alexkalderimis]

Thanks for taking a look @Shimuuar - I'll ping you once this has been updated.

[alexkalderimis]

Thanks for the suggestions @konsumlamm - please review the updated haddocks, which include some changes to fix failing doctests

[alexkalderimis]

@Shimuuar - the haddocks and specialized versions should be ready for your review now

[Shimuuar]

Thank you! PR look great.

Doctests fails because of extra whitespace. And could also mentiaion that function does not fuse, and resulting vectors are slices of original vector

[alexkalderimis]

Thank you! PR look great.

Thanks

Doctests fails because of extra whitespace.

D'oh - easy fix at least

And could also mentiaion that function does not fuse

Can do - thought this was not necessary since the result of the function is a list, not a Vector

and resulting vectors are slices of original vector

The haddocks say: "Split a vector into a list of slices." - is this enough?

[alexkalderimis]

Back to you, @Shimuuar

[Shimuuar]

Still one test failure. (It's really annoying that doctests only work on 8.6 & 8.8) otherwise good to go. Also could you add changelog entry while you at it

[alexkalderimis]

Still one test failure. (It's really annoying that doctests only work on 8.6 & 8.8) otherwise good to go. Also could you add changelog entry while you at it

It is a little annoying, especially since when I use 8.8.4 locally and run the test suite, I get errors like:

src/Data/Vector.hs:978: failure in expression `import qualified Data.Vector as V'
expected: 
 but got: 
          ^
          <no location info>: error:
              Could not find module ‘Data.Vector’
              Perhaps you meant Data.Functor (from base-4.13.0.0)

Tips on reproducing doctests locally would certainly, be appreciated, but I notice that the checks are running now on push so that is not a big deal.

It looks like I have fixed the remaining issues, so I have added the changelog entry, and squashed the commits for a cleaner history. Back to you @Shimuuar

[Shimuuar]

To run doctests one need not very secret incantation:

vector/.github/workflows/ci.yml

Line 86 in dae9d17

cabal build all --write-ghc-environment-files=always

I still hope we'll get doctests which just works and don't combust spontaneously.

Thank you, it's been a pleasure. Also thank you @konsumlamm for proofreading haddocks