Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type on hover #40

Merged
merged 5 commits into from
Jan 15, 2018
Merged

Show type on hover #40

merged 5 commits into from
Jan 15, 2018

Conversation

halhenke
Copy link
Contributor

Added an option to automatically show the type for a selected expression feature when the user hovers over an expression (appears at the bottom of the popover after currently displayed information).

show-type

Also added options for how to display the same information when using the show type command menu & moved the configuration setting about showing trace information into the proper scope (not sure if you want to keep it?)

- Basic attempt to format hoverType results with Markdown...

Add configuration option to enable/disable Show Expression on Hover
- Simplify implementation and remove some dead code
- Tried to use configurationChange API but does not seem to function yet
- Move the trace option into configuration and name appropriately
 - Check if cursor position is within selection before showing selected type information
- Get actual Haskell expression from selection to show in type information rather than using placeholder
- tweak configuration details
- reorder code
@AlexeyRaga
Copy link
Contributor

👍 That's awesome! //cc @alanz in case of GH notifications problem

@alanz alanz merged commit a10d6d0 into haskell:master Jan 15, 2018
@alanz
Copy link
Collaborator

alanz commented Jan 15, 2018

Published as v 0.0.7, thanks

@alanz
Copy link
Collaborator

alanz commented Jan 15, 2018

@halhenke
Copy link
Contributor Author

@alanz Nice 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants