Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup the test suite #475

Merged
merged 16 commits into from
Oct 5, 2021
Merged

Setup the test suite #475

merged 16 commits into from
Oct 5, 2021

Conversation

jneira
Copy link
Member

@jneira jneira commented Sep 29, 2021

@jneira jneira marked this pull request as draft September 29, 2021 08:42
@jneira
Copy link
Member Author

jneira commented Sep 30, 2021

Plan for the initial test suite:

  • Test the happy path, no the error handling (although it is important too)
  • Dont test things already tested in hls (diagnostics, code actions, etc)

@jneira
Copy link
Member Author

jneira commented Oct 4, 2021

Next step is figure out how to test the setup of the server (downloading the wrapper, querying the project ghc version, downloading hls, calling it)

@jneira jneira marked this pull request as ready for review October 5, 2021 09:36
@jneira
Copy link
Member Author

jneira commented Oct 5, 2021

I think the pr is useful as is, cause it at least compile and check the extension can be activated. Will add more tests in future prs

@jneira jneira merged commit 28d7b2b into haskell:master Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant