Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrades Z-Wave JS UI to v8.8.5 #463

Closed
wants to merge 2 commits into from

Conversation

Vaarlion
Copy link

@Vaarlion Vaarlion commented Feb 11, 2023

@frenck frenck added the dependencies Upgrade or downgrade of project dependencies. label Feb 12, 2023
@roblandry
Copy link
Contributor

I was able to get this to work by adding:
python3-dev=3.10.10-r0 and nodejs=18.14.1-r0

@Vaarlion
Copy link
Author

Vaarlion commented Feb 19, 2023

Sorry, i'm having some work issue and didn't took the time to look at the result of the pipeline.

i don't know what base is used for the hassio-addons image, but it look like the previous pkg version are nolonger available in the pkg repository.
Thank's @roblandry for finding working version !

I could build it and have it run, so i'm requesting a new pipeline run :)

@frenck
Copy link
Member

frenck commented Feb 20, 2023

Sorry, i'm having some work issue and didn't took the time to look at the result of the pipeline.

It also means you didn't test this at all, didn't you?

@Vaarlion
Copy link
Author

Sorry, i'm having some work issue and didn't took the time to look at the result of the pipeline.

It also means you didn't test this at all, didn't you?

Yes, like i've initialy wrote on the PR :

Sadly the use of a repository for this repo mean i couldn't just import it and test it.

I don't know much about how HA addons work and i don't have a zstick available to test it anyway.

@frenck
Copy link
Member

frenck commented Feb 20, 2023

Alright, in that case, I'll close the PR. Please, don't make PRs you can't or haven't tested. It wastes time for not just yourself, but also for people that review and discuss PRs.
You ain't helping anybody by doing drive-by PRs.

../Frenck

@frenck frenck closed this Feb 20, 2023
@roblandry
Copy link
Contributor

@Vaarlion I apologize for stealing your PR. My intentions were to wait it out, however, I required an update due to upstream changes. Im currently running my own version, in my main branch until the PRs all get merged.

Also, Frenck (intentionally not tagged) I apologize for posting on a closed PR, but it was my only means of commenting to the OP.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Upgrade or downgrade of project dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants