-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Upgrades Z-Wave JS UI to v8.8.5 #463
Conversation
I was able to get this to work by adding: |
Sorry, i'm having some work issue and didn't took the time to look at the result of the pipeline. i don't know what base is used for the hassio-addons image, but it look like the previous pkg version are nolonger available in the pkg repository. I could build it and have it run, so i'm requesting a new pipeline run :) |
It also means you didn't test this at all, didn't you? |
Yes, like i've initialy wrote on the PR :
I don't know much about how HA addons work and i don't have a zstick available to test it anyway. |
Alright, in that case, I'll close the PR. Please, don't make PRs you can't or haven't tested. It wastes time for not just yourself, but also for people that review and discuss PRs. ../Frenck |
@Vaarlion I apologize for stealing your PR. My intentions were to wait it out, however, I required an update due to upstream changes. Im currently running my own version, in my main branch until the PRs all get merged. Also, Frenck (intentionally not tagged) I apologize for posting on a closed PR, but it was my only means of commenting to the OP. |
Proposed Changes
Upgrades Z-Wave JS UI to v8.8.5