Merge pull request #88 from shahidhk/issue-83

close #83, prefix regsecret with remote name
hasura · Jul 27, 2018 · c1a0111 · c1a0111
2 parents f87df24 + f908495
commit c1a0111
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pkg/cmd/remote_generate.go b/pkg/cmd/remote_generate.go
@@ -249,8 +249,7 @@ dockerRegistryPrompt:
 	if !skipRegistry {
 		s := corev1.Secret{
 			ObjectMeta: metav1.ObjectMeta{
-				// TODO: handle secret name conflicts
-				Name:      "regsecret",
+				Name:      o.Remote.GetName() + "-regsecret",
 				Namespace: o.Remote.GetNamespace(),
 			},
 			Type: corev1.SecretTypeDockerConfigJson,
@@ -284,7 +283,7 @@ dockerRegistryPrompt:
 		o.Remote.Spec.Registry = v1alpha1.RegistrySpec{
 			Url: fmt.Sprintf("%s/%s", registry, username),
 			Credentials: v1alpha1.CredentialsSpec{
-				SecretRef: "regsecret",
+				SecretRef: o.Remote.GetName() + "-regsecret",
 			},
 		}
 	}