fix #78, handle permissions for docker.sock in a better way

[shahidhk]

@tirumaraiselvan This PR fixes #78. But, while testing some other issue with certain parameters in sshd_config being deprecated has appeared. Please check once before merging.

The following lines appear continuously with different port numbers in the logs for gitkubed:

rexec line 19: Deprecated option KeyRegenerationInterval
rexec line 20: Deprecated option ServerKeyBits
rexec line 31: Deprecated option RSAAuthentication
rexec line 38: Deprecated option RhostsRSAAuthentication
Could not load host key: /etc/ssh/ssh_host_dsa_key
Did not receive identification string from 10.1.0.1 port 43146

[tirumaraiselvan]

Can you test this on minikube? I can't run minikube on mine :/

Have tested this on GKE.

[tirumaraiselvan]

You can remove /hasura-data/group mount from the deployment.

[tirumaraiselvan]

To remove the deprecated messages in the logs, just remove the deprecated options from sshd_config

sed -i '/KeyRegenerationInterval/d' /etc/ssh/sshd_config
sed -i '/ServerKeyBits/d' /etc/ssh/sshd_config
sed -i '/RSAAuthentication/d' /etc/ssh/sshd_config
sed -i '/RhostsRSAAuthentication/d' /etc/ssh/sshd_config

[tirumaraiselvan]

Also comment the line HostKey /etc/ssh/ssh_host_dsa_key to remove the host_dsa_key line

[shahidhk]

@tirumaraiselvan To remove the deprecated messages, you've mentioned /etc/ssh/sshd_config. But aren't we using /sshd-lib/sshd_config?

[tirumaraiselvan]

@shahidhk Right. You just need to remove it from here https://github.com/hasura/gitkube/blob/master/build/gitkubed/sshd_config

[shahidhk]

I figured.

[shahidhk]

@tirumaraiselvan Any idea about Did not receive identification string from 172.17.0.1 port 58866?