-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
docker-compose/README.md
Outdated
raven: | ||
image: hasuranightly/raven:94a0141 | ||
ports: | ||
- "9000:8080" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the port as 8080?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. I pushed again.
docker-compose/README.md
Outdated
- "postgres:postgres" | ||
command: > | ||
/bin/sh -c " | ||
sleep 5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this sleep required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because raven needs to wait for the postgres server to come up. It crashes otherwise. Do you know a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it can keep restarting right? Just like with kubernetes. "Eventually" everything will be up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think restarting will happen on docker compose. May be docker stack.
Isn't there a way of mentioning dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a way in the older version, but it isn't available now docker/compose#4305. Now you have to write a wrapper script or something to check whether dependent services are up or not.
https://docs.docker.com/compose/startup-order/
@karthikvt26 can you add a separate docker-compose.yaml instead of putting.it in readme? |
No description provided.