Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

Adds docker-compose #2

Merged
merged 4 commits into from
Jun 19, 2018
Merged

Adds docker-compose #2

merged 4 commits into from
Jun 19, 2018

Conversation

karthikvt26
Copy link
Contributor

No description provided.

@karthikvt26 karthikvt26 requested a review from shahidhk June 14, 2018 15:22
raven:
image: hasuranightly/raven:94a0141
ports:
- "9000:8080"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep the port as 8080?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I pushed again.

- "postgres:postgres"
command: >
/bin/sh -c "
sleep 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this sleep required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because raven needs to wait for the postgres server to come up. It crashes otherwise. Do you know a better way?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it can keep restarting right? Just like with kubernetes. "Eventually" everything will be up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think restarting will happen on docker compose. May be docker stack.

Isn't there a way of mentioning dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a way in the older version, but it isn't available now docker/compose#4305. Now you have to write a wrapper script or something to check whether dependent services are up or not.
https://docs.docker.com/compose/startup-order/

@shahidhk
Copy link
Member

@karthikvt26 can you add a separate docker-compose.yaml instead of putting.it in readme?

@arvi3411301 arvi3411301 merged commit 4516856 into master Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants