Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update packages #161

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

AhmedElbohoty
Copy link
Contributor

@AhmedElbohoty AhmedElbohoty commented Aug 20, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Update following packages:
  • d3
  • stylelint
  • stylelint-config-sass-guidelines
  • sass
  • prettier
  • postcss
  • postcss-cli
  • live-server
  • gh-pages
  • @types/jest
  • @types/live-server
  • @types/node

Remove following packages:

  • mkdirp
  • What is the current behavior? (You can also link to an open issue here)
    The same current behavior.

  • What is the new behavior (if this is a feature change)?
    No new behavior.

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for racingbars ready!

Name Link
🔨 Latest commit 71a444a
🔍 Latest deploy log https://app.netlify.com/sites/racingbars/deploys/66c575d2673596000842ef5f
😎 Deploy Preview https://deploy-preview-161--racingbars.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AhmedElbohoty
Copy link
Contributor Author

Hello @hatemhosny:

Do you still need the gh-pages?

@hatemhosny
Copy link
Owner

hatemhosny commented Aug 21, 2024

Thank you @AhmedElbohoty

Do you still need the gh-pages?

Although we are not directly using gh-pages, I still find it to be convenient for anybody who forks the repo to just run npm run deploy and get the website deployed without having to configure any cloud provider.
I think we should just keep it for now.

Let's also keep tslib as it would be needed for some typescript features.

I have recently added @inquirer/prompts by mistake to dependencies. Would you kindly move it to devDependencies?

Thank you

@hatemhosny
Copy link
Owner

Have I missed merging this or was it not ready?

@AhmedElbohoty
Copy link
Contributor Author

Have I missed merging this or was it not ready?

It’s not done yet. Upgrading Docusaurus has caused build issues, and I’m still looking into it.

@AhmedElbohoty
Copy link
Contributor Author

Thank you @AhmedElbohoty

Do you still need the gh-pages?

Although we are not directly using gh-pages, I still find it to be convenient for anybody who forks the repo to just run npm run deploy and get the website deployed without having to configure any cloud provider. I think we should just keep it for now.

Let's also keep tslib as it would be needed for some typescript features.

I have recently added @inquirer/prompts by mistake to dependencies. Would you kindly move it to devDependencies?

Thank you

Okay. You can merge this pull request now.

@hatemhosny
Copy link
Owner

Okay. You can merge this pull request now.

That's great. Thank you.

It’s not done yet. Upgrading Docusaurus has caused build issues, and I’m still looking into it.

That's fine. Take your time. I expect so.
I have swizzled some components to integrate the expanding code block below charts. So may be the new version has introduced some changes.

Thank you.

@hatemhosny hatemhosny merged commit 2186584 into hatemhosny:develop Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants