upload-imageのoutputsにrevisionを追加 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
halkt
commented
Dec 25, 2023
•
halkt
commented
- .github/actions/upload-images.yamlのoutputsにrevisionを追加しました
- .github/actions/push-draft.yamlでrevisionを受け取れるように変更しました
halkt
force-pushed
the
add-outputs-upload-images
branch
from
b23b3a0
to
3c8c37c
Compare
halkt
force-pushed
the
add-outputs-upload-images
branch
from
3c8c37c
to
bff64b7
Compare
theoremoon
reviewed
Dec 26, 2023
.github/workflows/push-draft.yaml
Outdated
| @@ -2,6 +2,10 @@ name: "[Reusable workflows] push draft to hatena blog" | |||
|
|
|||
| on: | |||
| workflow_call: | |||
| inputs: | |||
| revision: | |||
| default: ${{ github.event.pull_request.head.sha }} | |||
There was a problem hiding this comment.
actions/checkoutのrefのデフォルト値は'' のようなのでここもデフォルト空文字列にしておいて、なにもなければactions/checkout のデフォルトの挙動に合わせる、でもよいかな〜と思っていました
theoremoon
approved these changes
Dec 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.