Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate misleading cache flag from store #218

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Mar 28, 2024

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Bug Fix

Proposed Changes:

  • The --cache flag under hauler store was misleadingly left behind from a much earlier release before introducing cosign for image handling.

  • Deprecating to stop confusion as it does absolutely nothing in the current versions of Hauler. Will remove completely at a later time.

Verification/Testing of Changes:

  • Flag deprecated...
❯ hauler store --help 
Interact with hauler's embedded content store

Usage:
  hauler store [flags]
  hauler store [command]

Aliases:
  store, s

Available Commands:
  add         Add content to store
  copy        Copy all store contents to another OCI registry
  extract     Extract content from the store to disk
  info        Print out information about the store
  load        Load a content store from a store archive
  save        Save a content store to a store archive
  serve       Expose the content of a local store through an OCI compliant registry or file server
  sync        Sync content to the embedded content store

Flags:
      --cache string   (deprecated and currently not used)
  -h, --help           help for store
  -s, --store string   Location to create store at (default "store")

Global Flags:
  -l, --log-level string    (default "info")

Additional Context:

Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
@amartin120 amartin120 changed the title removed misleading cache flag from store remove misleading cache flag from store Mar 28, 2024
@amartin120 amartin120 requested a review from dweomer March 28, 2024 18:53
Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with minor question/concern)

@zackbradys zackbradys added bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work labels Mar 28, 2024
@amartin120 amartin120 changed the title remove misleading cache flag from store deprecate misleading cache flag from store Mar 29, 2024
Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
@amartin120 amartin120 merged commit 5c7dadd into hauler-dev:main Mar 29, 2024
1 check passed
@amartin120 amartin120 deleted the remove-cache-flag branch March 29, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants