Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging for files #221

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Conversation

amartin120
Copy link
Contributor

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Bugfix

Proposed Changes:

  • The logging for syncing or adding a file to the store depended on supplying a name used for overriding which is obviously optional. So you would get something like below if you didn't pass the --name flag.
❯ hauler store add file https://raw.githubusercontent.com/zackbradys/code-templates/main/k8s/yamls/rancher-banner-tssci.yaml  
2024-04-01 12:10:46 INF adding 'file' [] to the store
2024-04-01 12:10:46 INF successfully added 'file' [hauler/rancher-banner-tssci.yaml:latest]

With this PR, you get

❯ hauler store add file https://raw.githubusercontent.com/zackbradys/code-templates/main/k8s/yamls/rancher-banner-tssci.yam
2024-04-01 12:17:30 INF adding 'file' [https://raw.githubusercontent.com/zackbradys/code-templates/main/k8s/yamls/rancher-banner-tssci.yaml] to the store
2024-04-01 12:17:30 INF successfully added 'file' [hauler/rancher-banner-tssci.yaml:latest]

Verification/Testing of Changes:

  • tested via hauler store add file and hauler store sync

Additional Context:

Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
@amartin120 amartin120 requested a review from dweomer April 1, 2024 16:33
@amartin120 amartin120 merged commit f6f2275 into hauler-dev:main Apr 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants