Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for dup digest smashing in cosign #234

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Apr 23, 2024

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Bugfix. Shared digests are getting smashed in the index.json due to a change made in our cosign fork for the last release. I've reverted that change in a new tag v2.2.3+carbide.2.

Proposed Changes:

  • Reverted change in our cosign fork that was put into place to keep duplicates out of the index.json if you ran the image add command twice but that didn't jive well when 2 different images shared layers. Sticking with the lesser of the 2 evils.

Verification/Testing of Changes:

  • Tested with the longhorn and mirrored-longhorn images. (Thanks Brian Durden)

Additional Context:

Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
@amartin120 amartin120 requested a review from dweomer April 23, 2024 19:04
Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (this sounds fun, and by bun i mean the opposite of such)

@amartin120 amartin120 merged commit fe88d70 into hauler-dev:main Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants