Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formatted all code with go fmt #248

Merged
merged 3 commits into from
Jun 14, 2024
Merged

formatted all code with go fmt #248

merged 3 commits into from
Jun 14, 2024

Conversation

zackbradys
Copy link
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

  • N/A

Types of Changes:

  • Feature

Proposed Changes:

  • Formatted all code with go fmt to ensure all code were formatted the same way

Verification/Testing of Changes:

  • Clone the repository and view the formatted code

Additional Context:

  • N/A

@zackbradys zackbradys requested review from amartin120 and dweomer June 8, 2024 14:12
@zackbradys zackbradys self-assigned this Jun 8, 2024
@zackbradys zackbradys added enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work labels Jun 8, 2024
Copy link
Contributor

@dweomer dweomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me except for the imports. Deps within import blocks are ordered alphabetically which is correct but there should really be a top-level block for stdlib items, followed by a blank line, and then 1 or more blocks for external/gomod dependencies. I don't care about the ordering of external stuff (though I tend to prefer like/related deps in the same block) so much as I really dislike the noise of external deps interleaved withing stdlib deps.

@zackbradys
Copy link
Member Author

zackbradys commented Jun 12, 2024

hey @dweomer, happy to make changes, but is there a better formatting tool/command/script we can use and recommend to users? if we are structuring the code differently from go fmt then we will need to add extra steps for users submitting PRs to ensure with have the same code structure.

@zackbradys zackbradys requested a review from dweomer June 14, 2024 03:45
@zackbradys zackbradys merged commit 0ec77b4 into hauler-dev:main Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants