Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image ref keys getting squashed when containing sigs/atts #291

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Aug 13, 2024

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Bugfix

Proposed Changes:

  • A recent change removed the KindAnnotationName from a map key of OCI objects, so when an image with a signature and/or attestations were added, the key value used for them matched the image itself so they were getting squashed out of the map.

Verification/Testing of Changes:

  • Added an <image:tag> with signatures and attestations.

    • hauler store info showed everything present.
    • hauler store serve registry served fine.
    • hauler store save/load worked appropriately
  • Added an <image:sha> with signatures and attestations.

    • hauler store info showed everything present.
    • hauler store serve registry served fine.
    • hauler store save/load worked appropriately
  • Added an <image:tag> WITHOUT signatures or attestations.

    • hauler store info showed everything present.
    • hauler store serve registry served fine.
    • hauler store save/load worked appropriately
  • Added an <image:sha> WITHOUT signatures or attestations.

    • hauler store info showed everything present.
    • hauler store serve registry served fine.
    • hauler store save/load worked appropriately

Additional Context:

amartin120 and others added 2 commits August 13, 2024 14:54
Signed-off-by: Adam Martin <adam.martin@rancherfederal.com>
Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
@dweomer dweomer merged commit c592551 into hauler-dev:main Aug 13, 2024
1 check passed
@zackbradys zackbradys added bug Something isn't working size/S Denotes an issue/PR requiring a relatively small amount of work priority/review labels Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/review size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

3 participants