Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed incorrectly named consts #371

Merged
merged 3 commits into from
Dec 4, 2024
Merged

renamed incorrectly named consts #371

merged 3 commits into from
Dec 4, 2024

Conversation

zackbradys
Copy link
Member

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • Bugfix

Proposed Changes:

  • Renamed consts to more accurately describe them

Verification/Testing of Changes:

  • N/A

Additional Context:

  • N/A

@zackbradys zackbradys requested a review from a team November 24, 2024 06:53
@zackbradys zackbradys self-assigned this Nov 24, 2024
@zackbradys zackbradys added bug Something isn't working enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work labels Nov 24, 2024
@zackbradys zackbradys added this to the Hauler v1.1-next1 milestone Nov 24, 2024
@zackbradys zackbradys linked an issue Nov 24, 2024 that may be closed by this pull request
[nit] manifest and config file constants incorrectly name-spaced (not part of oci spec afaict) #366
Closed
@zackbradys zackbradys requested a review from a team December 4, 2024 19:21
@zackbradys zackbradys merged commit 01faf39 into hauler-dev:main Dec 4, 2024
1 check passed
@zackbradys zackbradys deleted the updated-misnamed-consts branch December 4, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CamrynCarter CamrynCarter CamrynCarter approved these changes

@dweomer dweomer dweomer approved these changes

Assignees

@zackbradys zackbradys

Labels
bug Something isn't working enhancement New feature or request size/S Denotes an issue/PR requiring a relatively small amount of work
Projects
Hauler
Status: Resolved
Milestone
Hauler v1.1.1
Development

Successfully merging this pull request may close these issues.

[nit] manifest and config file constants incorrectly name-spaced (not part of oci spec afaict)
3 participants
@zackbradys @dweomer @CamrynCarter