Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned logging #22

Merged
merged 6 commits into from
Dec 6, 2024
Merged

Cleaned logging #22

merged 6 commits into from
Dec 6, 2024

Conversation

hajothelen
Copy link
Contributor

@hajothelen hajothelen commented Dec 5, 2024 •
edited
Loading

The SLF4J Logger was not correctly used. Now the Logger should be used in a proper way all over the project.

haumacher
haumacher requested changes Dec 5, 2024
View reviewed changes
Copy link
Owner

@haumacher haumacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question regarding log signature - can the signature with message and exception changed to the pattern with arguments signature?

mjsip-phone/src/main/java/org/mjsip/phone/gui/StringList.java Show resolved Hide resolved
@hajothelen
Update UserAgent.java
df6d23f 
There was a toString I've missed
@hajothelen
Update UserAgentCli.java
1b2d831 
another toString I've missed
@haumacher haumacher merged commit 5ac4212 into haumacher:master Dec 6, 2024
1 check passed
@haumacher
Copy link
Owner

Thanks a lot for your contribution! That's a nice code improvement!

@hajothelen hajothelen deleted the cleaned_logging branch December 6, 2024 07:29
@hajothelen hajothelen restored the cleaned_logging branch December 6, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haumacher haumacher haumacher requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hajothelen @haumacher