Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --additional-flags argument #50

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Add --additional-flags argument #50

merged 1 commit into from
Nov 9, 2022

Conversation

JelleZijlstra
Copy link
Collaborator

So we can use it in typeshed to disable bytearray/memoryview promotions

@JelleZijlstra
Add --additional-flags argument
2d8feb6 
So we can use it in typeshed to disable bytearray/memoryview promotions
hauntsaninja
hauntsaninja reviewed Nov 9, 2022
View reviewed changes
Copy link
Owner

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work? Won't you have to either stick hyphens back on or use argparse.REMAINDER or something?

@JelleZijlstra
Copy link
Collaborator Author

Yes, I tested locally with like --additional-flags="--skip-bytearray-promotion --skip-memoryview-promotion".

@hauntsaninja
Copy link
Owner

Oh right, I forgot about equals. Thanks!

@hauntsaninja hauntsaninja merged commit ceecd71 into hauntsaninja:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @hauntsaninja