Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PayPal, CashApp, and Venmo support to Haveno #971

Closed
wants to merge 1 commit into from

Conversation

preland
Copy link
Contributor

@preland preland commented May 27, 2024

This PR addresses #948 and #685 by adding PayPal and CashApp as payment methods to Haveno. Venmo is also added, as it had some pre-existing code alongside CashApp from Bisq.

@preland preland requested a review from woodser as a code owner May 27, 2024 18:24
@woodser
Copy link
Contributor

woodser commented Jun 2, 2024

Please also register the form IDs in PaymentAccountForm.java and ensure the test "Can validate payment account forms" passes in HavenoClient.test.ts, so they're fully integrated with the API.

Additionally, the payment methods need a warning popup about their high chargeback risk, shown when the payment account is created.

@preland
Copy link
Contributor Author

preland commented Jun 2, 2024

On it; it should already be showing the chargeback risk screen when creating an account

@woodser
Copy link
Contributor

woodser commented Jun 4, 2024

FYI, Australia PayID was integrated and tested with the API in these PRs, for reference:

#994
haveno-dex/haveno-ts#288

@woodser
Copy link
Contributor

woodser commented Jun 7, 2024

I'd like to get this wrapped up for next release. I'm planning to work on it today, so might open a PR on your branch for inclusion.

@woodser
Copy link
Contributor

woodser commented Jun 8, 2024

Superseded by #1007

@woodser woodser closed this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants