Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): callback not being called #101 #102

Merged
merged 1 commit into from
Oct 21, 2023
Merged

fix(ios): callback not being called #101 #102

merged 1 commit into from
Oct 21, 2023

Conversation

miteshsavani810
Copy link

@miteshsavani810 miteshsavani810 commented Jun 25, 2021 •
edited by erisu
Loading

Description

Fixed: on iOS, Callback function is not called when user click notification action where foreground: true

Resolves #101

Motivation and Context

How Has This Been Tested?

Tested on iPhone 6s (iOS 14).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@miteshsavani810
Fixed (ios) Callback is not called Issue phonegap#101
92a90a0 
Fixed: on iOS, Callback function is not called when user click notification action where foreground: true
@erisu erisu changed the title Fixed (ios) Callback is not called Issue #101 fix(ios): callback not being called #101 Apr 11, 2022
@erisu erisu merged commit 9cbc67c into havesource:master Oct 21, 2023
scyclops added a commit to scyclops/cordova-plugin-push that referenced this pull request Nov 7, 2023
@scyclops
callback fix from upstream havesource#102
a5868eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on iOS, Callback function is not called when user click notification action where foreground: true
2 participants
@miteshsavani810 @erisu