feat!(android): migrate source code to kotlin #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* kotlin@1.5.20 * add before_compile hookscript for cordova-android 9.x support
…LEAR_ALL_NOTIFICATIONS action
moved it internal to sendExtras to remove the conflict of choise prviate/internal.
erisu
added a commit
that referenced
this pull request
Sep 15, 2021
* feat!(android): add kotlin support * kotlin@1.5.20 * add before_compile hookscript for cordova-android 9.x support * refactor!: convert PushInstanceIDListenerService to Kotlin * refactor!: convert PushDismissedHandler to Kotlin * refactor!: convert BackgroundActionButtonHandler to Kotlin * refactor!: convert PushConstants to Kotlin * refactor!: convert BackgroundHandlerActivity to Kotlin * refactor!: convert PushHandlerActivity to Kotlin * refactor!: convert PushPlugin to Kotlin * refactor!: convert FCMService to Kotlin * fix: target-dir path for kotlin files * refactor: BackgroundActionButtonHandler * refactor: PushInstanceIDListenerService * refactor: BackgroundHandlerActivity * refactor: PushDismissedHandler * refactor: PushHandlerActivity * refactor: PushConstants * refactor: PushPlugin * refactor: PushPlugin - separate INITIALIZE action * refactor: PushPlugin - separate UNREGISTER action * refactor: PushPlugin - separate HAS_PERMISSION action * refactor: PushPlugin - separate SET_APPLICATION_ICON_BADGE_NUMBER action * refactor: PushPlugin - separate GET_APPLICATION_ICON_BADGE_NUMBER & CLEAR_ALL_NOTIFICATIONS action * refactor: PushPlugin - separate SUBSCRIBE action * refactor: PushPlugin - separate UNSUBSCRIBE action * refactor: PushPlugin - separate CREATE_CHANNEL action * refactor: PushPlugin - separate DELETE_CHANNEL action * refactor: PushPlugin - separate LIST_CHANNELS action * refactor: PushPlugin - separate CLEAR_NOTIFICATION action * refactor: Invalid Execute Action Log * refactor: PushPlugin * refactor: remove unused sendError * refactor: remove unused import * refactor: PushPlugin - moved compainion object to top * refactor: PushPlugin - commenting * refactor: PushPlugin - move onPause super call to bottom * refactor: PushPlugin - removed unused var registration_id * refactor: PushPlugin - removed getStringResourceByName * refactor: PushPlugin - convertBundleToJson * moved it internal to sendExtras to remove the conflict of choise private/internal. * chore(lint): remove comments from private methods (CommentOverPrivateFunction) * chore(lint): move comments from private methods inside (CommentOverPrivateFunction) * refactor: FCMService - reformat * refactor: FCMService - reformat again * refactor: FCMService - reformat some more * refactor: add IS_ENABLED to PushConstants * refactor: FCMService LOG_TAG to TAG * chore: remove lint warning CommentOverPrivateProperty * chore: fix some lint warnings in FCMService * chore: removing duplicated code * chore: removing duplicated code (pushSharedPref) * refactor: FCMService continue * fix: remove AppCompatActivity reference * chore: type cast cordova.activity as Activity * fix: remove some code warnings in FCMService * chore: update tag to include plugin name for better logcat filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate to Kotlin
Related Issue
Motivation and Context
Cleaner and Eaiser
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: