fix(android): processPushBundle flipped returned value #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Appears that during refactoring from Java to Kotlin, the returned value of
processPushBundle
was flipped.When reading the code, I was expecting that the returned value was only
true
when the inline reply exists. This is determined ifRemoteInput.getResultsFromIntent
was not null.I expected this case because the variable name
inline
, but the variable name was not actually detailed enough to explain if it washas
vsnotHave
.Compaing with Java code, it appears that
true
is always returned even when there is no inline reply. So this means when Inline reply is set, then false is returned.This PR should flip the case back and I also renamed the variable
inline
tonotHaveInlineReply
to properly explain what the return result represents.Related Issue
fixes #149
Motivation and Context
Fixes the flipped return value in
processPushBundle
.How Has This Been Tested?
n/a
Screenshots (if appropriate):
Types of changes
Checklist: