Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows)!: remove deprecated platform #245

Merged
merged 4 commits into from
Oct 1, 2023
Merged

fix(windows)!: remove deprecated platform #245

merged 4 commits into from
Oct 1, 2023

Conversation

seamlink-aalves
Copy link

Since Windows platoform has been marked as deprecated this PR removes the deprecated platform

How Has This Been Tested?

Ran cordova plugin add

@erisu erisu changed the title fix!: remove deprecated platforms fix(windows)!: remove deprecated platform Sep 30, 2023
@erisu
Copy link

erisu commented Sep 30, 2023

@seamlink-aalves I think there are few other places in the repo that was missed.

E.g.

  • .eslintrc.yml
  • plugin.xml
    <description>Enable receiving push notifications on Android, iOS and Windows devices. Android uses Firebase Cloud Messaging. iOS uses Apple APNS Notifications. Windows uses Microsoft WNS Notifications.</description>
    
  • docs\API.md
  • docs\EXAMPLES.md
  • docs\PAYLOAD.md
  • spec\index.spec.js

If you can remove all, that would be nice. Some of the areas are sentences so you might have to modify the sentence to remove Windows reference but not delete the entire sentence.

You should be able to find all references by using windows as the search keyword..

The only place that should not be removed is from .github\workflows\ci.yml... This is just to tests if there is any issues using windows as a development environment. Not related to the Cordova-Windows platform.

@seamlink-aalves
Copy link
Author

Hi @erisu, I've removed the remaing windows platform references.

Copy link

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit 45d65b1 into havesource:master Oct 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants