Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoverProvider duplicates when Detach/Attach Editor #41

Closed
hawkerm opened this issue Mar 29, 2020 · 3 comments
Closed

HoverProvider duplicates when Detach/Attach Editor #41

hawkerm opened this issue Mar 29, 2020 · 3 comments
Labels
Milestone

Comments

@hawkerm
Copy link
Owner

hawkerm commented Mar 29, 2020

I think this is related to the creation/descruction of the ModelHelper in the Loaded/Unloaded events, they also feel unnecessary, but removing them causes the HoverProvider to break entirely.

Should investigate cleaning this up and resolving this bug.

@hawkerm hawkerm added this to the v0.9-beta milestone Mar 29, 2020
@hawkerm hawkerm added the bug label Mar 29, 2020
@hawkerm
Copy link
Owner Author

hawkerm commented Mar 30, 2020

After the optimizations to the CssStyleBroker I'm not noticing this behavior anymore... though it could be related to if we re-create the style object for every decoration. Will have to test some more...

@hawkerm
Copy link
Owner Author

hawkerm commented Oct 21, 2021

Still seeing this, repro steps on beta branch:

  1. hover over 'Hit' word
  2. Click Detach
  3. Click Attach
  4. hover again see duplicate:

image

@hawkerm
Copy link
Owner Author

hawkerm commented Oct 21, 2021

Think this is an issue with the Loading event in the sample firing multiple times, testing out a fix to the sample.

The sample has another issue with the condition not being re-initialized in the remove/add scenario. (Edit: Nope, my condition is fine as it's re-setup in the loading event which fires in that scenario.)

hawkerm added a commit that referenced this issue Oct 21, 2021
@hawkerm hawkerm closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant