This repository has been archived by the owner on Jun 9, 2022. It is now read-only.
Extend java-owasp and java-find-secbugs modules to support kotlin #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Kotlin support using the existing java-owasp and java-find-secbugs modules (both tools support Kotlin projects).
Type of change
Toolchain
How Has This Been Tested?
Running dockerized hawkeye against a bare-bones kotlin spring boot project with outdated dependencies:
Rebuild the Hawkeye Container to get all the tools
Get a Kotlin Spring Boot project with vulnerable dependencies and build it
Run Hawkeye against the project. You should see some findings from find-secbugs about spring boot internals and dependencies with CVEs
You can add bug-patterns like a predictable pseudorandom number generator to the code, rebuild and re-scan to prove that application code is also scanned successfully.
Notes for reviewer
I decided to keep the module names as they are (java-find-secbugs, java-owasp) to avoid breaking changes. However, since they support more than one language (I'm guessing they could easily be extended to other JVM languages like Scala or Clojure) this is slightly misleading. Should we rename them to jvm-find-secbugs, jvm-owasp or something like that and if yes, do we need some kind of backwards compatibility? Or should we stick with the pattern "one module - one language" and create separate modules?
Checklist: