Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets value on a nil lasknown #1238

Merged
merged 2 commits into from
Apr 12, 2013
Merged

Sets value on a nil lasknown #1238

merged 2 commits into from
Apr 12, 2013

Conversation

CalebJohn
Copy link
Member

fixes #1215

@jhoff
Copy link
Member

jhoff commented Apr 11, 2013

lastknown is not a clone of the footprint, so this code is kinda dangerous. It'd be better to do this:

if self.lastknown then
    fp.x = self.lastknown.x
    fp.y = self.lastknown.y
end

@CalebJohn
Copy link
Member Author

that spawns the player behind the statue, and i'm not sure why its different

@CalebJohn
Copy link
Member Author

the reason i changed so much was the spacing was off and that bugged me

jhoff pushed a commit that referenced this pull request Apr 12, 2013
Sets value on a nil lasknown
@jhoff jhoff merged commit 95a2550 into hawkthorne:master Apr 12, 2013
@CalebJohn CalebJohn deleted the lastknown branch April 12, 2013 20:58
@danhp danhp mentioned this pull request Apr 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GameOver Bug
2 participants