Allows dropping of projectiles #1580
Conversation
|
This works for scrolls, throwing knives and icicles. but there are 2 different problems for others. You can drop throwing axes but they are just thrown off the screen so you can't pick them up again & I get a blue screen error saying something about nodes/ammo when I try to drop an arrow. |
ghost
assigned 
|
@edisonout Good find. Sentry tracker for the arrow error is here: https://app.getsentry.com/hawkthorne/journey-to-the-center-of-hawkthorne/group/6139503/ @CalebJohn Thanks for getting started on this. If you want any help testing and fixing all the various items to make sure everything's working, I'm your guy. |
|
@edisonout the arrow error is unrelated to this pull but has been addressed here #1579 , as for the throwing axes, I'll look into it right away, thanks. @bucketh3ad ya I think it may be related to #1570 but it looks like when you pick up projectiles you're picking up the max not the amount you droppped |
|
Throwing axes are now fixed, I'm thinking that we need to add more properties to the projectiles to give them a proper bounding box once dropped. |
|
I see you added a directory field to some of the weapons, but you don't use that field outside of the Scroll.lua, did you mean to use that elsewhere? |
|
Its already built in to projectile.lua so it is also being used there it's just not showing up in the diff |
|
That makes sense. My bad. On Thu, Jun 20, 2013 at 5:01 PM, Caleb John notifications@git.luolix.topwrote:
|
|
Good, except you can pick up projectiles you've thrown on the run if you hit the button quick enough. It's not a major problem with throwing knives, but it crashes with lightning since the projectile isn't the same as the inventory object. We need to differentiate between thrown and dropped projectiles somehow. |
|
@bucketh3ad could you check if this actually fixes it? I was able to duplicate once but could never get it again. |
|
Looks like that did the trick. Should be ready to merge. |
|
For throwing axes, you can throw them and you can pick them back up. Regular projectiles work fine though. EDIT: Arrows don't work, it crashes saying "nodes/ammo not found" |
Conflicts: src/inventory.lua fixes arrow drop crash and throwing axe
Conflicts: src/inventory.lua update to master
|
So Updated this to master and fixed dropping arrows and picking up throwing axes. |
|
The throwing axes are still really bugged, you can pick them up after you throw them. Arrows now work fine though. |
|
Sorry @didory123 I blame the bad fix on being really tired when I made my original claim this should return the axe to its old behavior. |
|
@CalebJohn This pull will be good after you fix the conflicts, just merge whenever you're ready |
Conflicts: src/inventory.lua update to master
|
done and done |
Allows dropping of projectiles
This gives projectiles and scrolls support to be dropped.
There is a bug where you can pick up more of a projectile then you dropped, I couldn't find this but I'm hoping @bucketh3ad might have a better idea.