Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valley redux #1607

Merged
merged 95 commits into from
Jul 5, 2013
Merged

Valley redux #1607

merged 95 commits into from
Jul 5, 2013

Conversation

didory123
Copy link
Member

Finished!

Files changed:

  • 9 new levels
  • Lots of NPCs and their images
  • Change healthpot to healthpotion
  • Get rid of the stick chest in Black Caverns
  • Change mariachi band, frog, and spider HPs and damages
  • Add two new weapons, crimson sword
  • Add superhealthpotion

Lots of thanks to reddfawks for the awesome sprites and protuhj for the spider (dropbear) code

EDIT: Ideally, the amount of time required for a full playthrough of the world should be 30-45 minutes. Please test from the beginning and tell me how long it takes to complete it.

@edisonout
Copy link
Member

I set up git on another machine and still have the same problem with the tileset not displaying and only seeing a white background instead. Didn't let this stop me. Pressed F5 so I could see the floor/holes and played through valley & valley 2. I fall through pretty much every corner/place two blocks meet and if I kill an enemy I fall through the floor. This happens on both computers I've tried. If someone can work out why I can't see the tileset I'll try actually testing the level and giving constructive criticism.

@reddfawks
Copy link
Contributor

Hmmm, is there a way you can "reset" the dropping platforms in the sand pits once they've fallen? (Maybe make them re-spawn on a timer, or have the player hit a switch to do so)?

Many times, if I missed the jump and landed back on the ground, or even bumped the next platform so that it dropped without me on it, I'd have to kill myself to get them to respawn so I could try again.

@danhp
Copy link
Member

danhp commented Jul 1, 2013

ok... single use platforms function very poorly. It should be recoded so we either have a timer on the drop or we have it actually drop only when on top of it and not just colliding the node.

@edisonout
Copy link
Member

Please tell me this bug is just my computer hating this level - I've realised I'm not falling through the floor at corners or when jumping on enemies, it's absolutely every time I jump on a platform. If I jump, it's like the level forgets that platform exists. If there's one above, I'll land on that, if not, I'll jump up & then fall through the platform I was on onto the one below.

@didory123
Copy link
Member Author

@edisonout Haha yeah, I think it is. So far, everybody else have managed to play the levels successfully and without any problems, really not sure why it's not working on yours.

@CalebJohn
Copy link
Member

I'm just gonna go ahead and say LGTM

@danhp
Copy link
Member

danhp commented Jul 5, 2013

LGTM
small tweaks here and there but we need to have more actual tester get more of them

danhp added a commit that referenced this pull request Jul 5, 2013
@danhp danhp merged commit a1fed22 into hawkthorne:master Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants