Board manages player control state #2367
Conversation
niamu
force-pushed
the
player_controlstate
branch
from
48f37b0 to
06414ac
Compare
|
LGTM. Is there anything else this pull could possibly affect that we need to test to make sure nothing else is broken somewhere else? |
|
Not that I can think of. Boards are used for dialogs and other prompts. Maybe have a quick look to see if we use board.lua for anything else? |
|
Enter the tavern and open your inventory. Once the dealer speaks to you and you close his dialog prompt, then you can start moving with your inventory. |
|
How do we feel about closing the inventory if a dialog pops up? |
|
I'm all for it, it may be a little annoying but really won't come up as an issue that often. |
Resolves the bug I previously created trying to have the player not move when a dialog is open.
niamu
force-pushed
the
player_controlstate
branch
from
06414ac to
e6d8d13
Compare
|
Inventory closes when a dialog opens. Hopefully that is the last of the issues with this pull request. |
|
LGTM |
|
I have a feeling that trying to open it again afterwards might not be worthwhile. The only time a dialog will ever really happen with the inventory open anyways is the tavern level. And that is within 3-4 seconds. Hopefully our players don't mind losing 3-4 seconds of crafting effort in that case which we wouldn't be able to restore for them by opening the inventory again anyways. |
|
You're right it won't be worth it, This is good for merging! |
Board manages player control state
Resolves #2361 which is a bug I previously created trying to have the player not move when a
dialog is open.