Airplane SFX only play if not muted #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thats my fault from the change to new collisions I forgot to remove the old stuff, LGTM |
CalebJohn
added a commit
that referenced
this pull request
May 16, 2015
Airplane SFX only play if not muted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use the old airplane.lua code anywhere in the game.
When changing audio settings within the greendale-exterior level from anything greater than 0 to mute, the airplane still makes noise but only at the point where it was when you made the change to 0.
The update code mistakenly checked to see if the SFX volume was 0 as to whether or not to move the audio location with the airplane. I moved this mute check to the enter function where we conditionally set whether we will have engine noise or not based on volume settings.
Resolves #2368.