Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with #102 and #103 merged into current main (ee45b4c), with Rust 1.83 (
rustc 1.83.0 (90b35a623 2024-11-26)
,cargo 1.83.0 (5ffbef321 2024-10-29)
), runningcargo clippy --all-targets --all-features
gives 16 lifetime-related lint warnings:Warnings
This is particularly problematic because it seems to be causing CI failures in PRs, such as in #102 and #103. This commit uses
cargo clippy --all-targets --all-features --fix
to fix all such warnings.I confirmed in my
fix-all-warnings-merged-together
branch that by starting with the current main (ee45b4c) and merging in #102, #103, and this branch, runningcargo check
andcargo clippy --all-targets --all-features
complete with no warnings.