Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated std::random_shuffle usage replaced. #1043

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Deprecated std::random_shuffle usage replaced. #1043

merged 5 commits into from
Dec 12, 2022

Conversation

OzanCansel
Copy link
Contributor

  • std::random_shuffle replaced with std::shuffle

Fixes #1042

@OzanCansel OzanCansel added this to the 5.1.0 milestone Dec 9, 2022
@OzanCansel OzanCansel self-assigned this Dec 9, 2022
@OzanCansel OzanCansel requested a review from ihsandemir December 9, 2022 12:11
@devOpsHazelcast
Copy link
Contributor

Linux test FAILed.

@devOpsHazelcast
Copy link
Contributor

Windows test FAILed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@OzanCansel OzanCansel merged commit 3c6e5e4 into hazelcast:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsandemir ihsandemir ihsandemir approved these changes

Assignees

@OzanCansel OzanCansel

Labels
compilation-error
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Doesn't compile on MSVC with C++17 because of deprecated STL method usage.
3 participants
@OzanCansel @devOpsHazelcast @ihsandemir