Incorrect Char array type number for portable serialization #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihsandemir
force-pushed
the
boolArrayTypeFix
branch
from
9d0ef4a to
bbed090
Compare
|
verify |
|
Test FAILed. |
sancar
reviewed
Mar 15, 2017
| static const FieldType TYPE_LONG_ARRAY(15); | ||
| static const FieldType TYPE_FLOAT_ARRAY(16); | ||
| static const FieldType TYPE_DOUBLE_ARRAY(17); | ||
| static const FieldType TYPE_BOOLEAN_ARRAY(11); |
…Added read/writeBooleanArray to portable reader/writer.
ihsandemir
force-pushed
the
boolArrayTypeFix
branch
from
bbed090 to
87c21f8
Compare
|
verify |
sancar
approved these changes
Mar 16, 2017
…portable has enough fields to test the portable serialization between java and c++ for a wider possibility of fields.
|
Test FAILed. |
1 similar comment
|
Test FAILed. |
…e string can be compiled.
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the Type number at FieldType class to be the same as Java. Added read/writeBooleanArray to portable reader/writer.
Fixes #230
Fixes #236