Do not re-schedule backup event timer if connection is closing and client is shutting down #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not being re-scheduled when the client being shutdown. Failing to do so causes the shutdown to hang up. Possible scenario for generating the problem: 1. Trigger client shutdown. 2. The backup timer expired and its lambda code is being executed. 3. The connection close cancels the timer but it is not effective since the time is not in the wait queue. 4. The timer is being rescheduled. Also, checked all the other timers, they all have similar checks. Changed the location of the check for the `ClientConnectionManagerImpl::schedule_connect_to_all_members` method. fixes hazelcast#900
yemreinci
approved these changes
Aug 20, 2021
yemreinci
reviewed
Aug 20, 2021
|
verify |
|
Windows test PASSed. |
|
Linux test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an extra check for re-scheduled backup event timer so that it is not being re-scheduled when the client being shutdown. Failing to do so causes the shutdown to hang up. Possible scenario for generating the problem:
Also, checked all the other timers, they all have similar checks. Changed the location of the check for the
ClientConnectionManagerImpl::schedule_connect_to_all_membersmethod.fixes #900
Please see reproducer test at reproducer branch.