-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projections added to python client #451
Conversation
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 86.06% 94.20% +8.14%
==========================================
Files 340 345 +5
Lines 17938 17545 -393
==========================================
+ Hits 15438 16529 +1091
+ Misses 2500 1016 -1484
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty code, left some more minor comments
verify |
@RobHam99 a test failed in Python 2. To fix this, we need to define Please add the following methods to hazelcast/core.py/HazelcastJsonValue class def __hash__(self):
return hash(self._json_string)
def __repr__(self):
return self._json_string |
verify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution Rob, I am merging this
project
method added to map.py, projection.py added includingIdentityProjection
,SingleAttributeProjection
andMultiAttributeProjection
.Closes #203