[API-700] v5 SQL: Initial PR #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial PR for the v5 SQL. It consists minimal changes required to test the v5 SQL. Follow up PRs will come after that. Here are the list of changes made: - Set client version to 5.0 - Update remote controller scripts so that it uses hazelcast+hazelcast-sql JARs instead of hazelcast-all, since hazelcast-all is not produced anymore. Also, update some documentation about it. - Use ints to represent years in DATE column type - Use built-in types for DATE, TIME, TIMESTAMP, TIMESTAMP WITH TIMEZONE, and DECIMAL which are datetime.date, datetime.time, datetime.datetime, datetime.datetime(with non-None tzinfo), and decimal.Decimal. - Update SQL tests and add some Jet tests - Fix distributed objects tests by filtering internal objects out.
Codecov Report
@@ Coverage Diff @@
## master #456 +/- ##
==========================================
- Coverage 94.45% 94.21% -0.25%
==========================================
Files 345 345
Lines 17545 17535 -10
==========================================
- Hits 16572 16520 -52
- Misses 973 1015 +42
Continue to review full report at Codecov.
|
|
Will there be documentation and code samples PRs after this? |
|
@srknzl, yes I will send them in a separate PR |
srknzl
reviewed
Aug 26, 2021
srknzl
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial PR for the v5 SQL. It consists minimal changes
required to test the v5 SQL. Follow up PRs will come after that.
Here are the list of changes made:
JARs instead of hazelcast-all, since hazelcast-all is not produced anymore.
Also, update some documentation about it.
which are datetime.date, datetime.time, datetime.datetime,
datetime.datetime(with non-None tzinfo), and decimal.Decimal.