Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-702] v5 SQL: Remove unused load balancer methods #458

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

mdumandag
Copy link
Contributor

These methods were specially added for 4.2 SQL, but they are unused
in v5. Hence, we are removing the unused methods and reverting the
changes we made around the load balancer implementations and tests.

Note that, it is perfectly safe to remove these methods in Python.
If there were users that implemented these methods, they can use
their code without changing anything.

@mdumandag mdumandag added this to the 5.0 milestone Aug 24, 2021
@mdumandag mdumandag self-assigned this Aug 24, 2021
@mdumandag mdumandag changed the title v5 SQL: Remove unused load balancer methods [API-702] v5 SQL: Remove unused load balancer methods Aug 26, 2021
These methods were specially added for 4.2 SQL, but they are unused
in v5. Hence, we are removing the unused methods and reverting the
changes we made around the load balancer implementations and tests.

Note that, it is perfectly safe to remove these methods in Python.
If there were users that implemented these methods, they can use
their code without changing anything.
@mdumandag mdumandag force-pushed the remove-unused-lb-methods branch from 834678b to b397bb7 Compare August 31, 2021 07:55
@codecov-commenter
Copy link

Codecov Report

Merging #458 (1055116) into master (da647b8) will decrease coverage by 0.31%.
The diff coverage is 86.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
- Coverage   94.51%   94.19%   -0.32%     
==========================================
  Files         345      345              
  Lines       17547    17563      +16     
==========================================
- Hits        16584    16543      -41     
- Misses        963     1020      +57     
Impacted Files Coverage Δ
hazelcast/sql.py 96.83% <72.72%> (-0.61%) ⬇️
hazelcast/util.py 83.90% <82.05%> (-0.71%) ⬇️
hazelcast/connection.py 90.81% <96.42%> (-1.70%) ⬇️
hazelcast/__init__.py 60.00% <100.00%> (ø)
hazelcast/protocol/builtin.py 94.45% <100.00%> (-0.13%) ⬇️
...otocol/codec/client_authentication_custom_codec.py 50.00% <0.00%> (-23.81%) ⬇️
hazelcast/reactor.py 79.56% <0.00%> (-7.55%) ⬇️
hazelcast/proxy/base.py 97.40% <0.00%> (-0.65%) ⬇️
hazelcast/statistics.py 88.02% <0.00%> (-0.60%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea8a19...1055116. Read the comment docs.

@mdumandag mdumandag merged commit d613fc8 into hazelcast:master Aug 31, 2021
@mdumandag mdumandag deleted the remove-unused-lb-methods branch August 31, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants