Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing remove_interceptor API to the Map #481

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

mdumandag
Copy link
Contributor

Also, added a test for the add_interceptor method.

Protocol PR: hazelcast/hazelcast-client-protocol#399

Also, added a test for the `add_interceptor` method.
@codecov-commenter
Copy link

Codecov Report

Merging #481 (d2ffcbf) into master (e9dfb0a) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   95.16%   94.93%   -0.24%     
==========================================
  Files         345      346       +1     
  Lines       17711    17730      +19     
==========================================
- Hits        16855    16832      -23     
- Misses        856      898      +42     
Impacted Files Coverage Δ
...ast/protocol/codec/map_remove_interceptor_codec.py 100.00% <100.00%> (ø)
hazelcast/proxy/map.py 89.77% <100.00%> (+0.59%) ⬆️
...otocol/codec/client_authentication_custom_codec.py 50.00% <0.00%> (-23.81%) ⬇️
hazelcast/reactor.py 81.79% <0.00%> (-7.53%) ⬇️
hazelcast/connection.py 91.88% <0.00%> (-1.42%) ⬇️
hazelcast/invocation.py 94.63% <0.00%> (-0.77%) ⬇️
...elcast/protocol/codec/map_add_interceptor_codec.py 100.00% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9dfb0a...d2ffcbf. Read the comment docs.

Copy link
Contributor

@yuce yuce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two trivial comments.

tests/integration/backward_compatible/proxy/map_test.py Outdated Show resolved Hide resolved
tests/integration/backward_compatible/proxy/map_test.py Outdated Show resolved Hide resolved
@mdumandag mdumandag merged commit bf30e1c into hazelcast:master Sep 20, 2021
@mdumandag mdumandag deleted the remove-interceptor branch September 20, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants