Fix custom lookup serializer for class error [API-1669] #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #603 +/- ##
==========================================
+ Coverage 96.47% 96.50% +0.02%
==========================================
Files 357 357
Lines 20510 20632 +122
==========================================
+ Hits 19787 19910 +123
+ Misses 723 722 -1
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mdumandag
reviewed
Dec 29, 2022
mdumandag
reviewed
Dec 30, 2022
mdumandag
reviewed
Jan 30, 2023
mdumandag
reviewed
Jan 30, 2023
Added multimap put-all
…azelcast#602) Bumps [hazelcast](https://github.com/hazelcast/hazelcast) from 5.1 to 5.1.3. - [Release notes](https://github.com/hazelcast/hazelcast/releases) - [Commits](hazelcast/hazelcast@v5.1...v5.1.3) --- updated-dependencies: - dependency-name: com.hazelcast:hazelcast dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Convert `Config` classes to public API These were converted into private classes during the 4.0 migration, as we were only supporting keyword arguments for the client configuration. However, that led to a poor user experience, as we had to use `**kwargs`, instead of listing all the configuration elements in the client constructor. (IDEs become painfully slow once we list all keyword arguments, as there are too many of them) The solution to this problem is to make the Config classes public API and make the client able to use it directly. ```python config = Config() config.cluster_name = "dev2" client = HazelcastClient(config) ``` We provide full type hints for config elements. * bump the client version used in tests * address review comments * shutdown clients in teardown method
…azelcast#604) Added code sample to show how Hazelcast works with Pandas DataFrames.
mdumandag
reviewed
Feb 20, 2023
There was a problem hiding this comment.
@fatihozer0 can you also take a look at the linter problems?
|
@fatihozer0 after you get the test failure fixed, we are ready to merge this |
added 2 commits
March 24, 2023 14:05
mdumandag
reviewed
Mar 24, 2023
|
I have committed the latest changes I have asked myself to include this PR and the JIRA task in the 5.2 release, which we will start testing today. |
mdumandag
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #591