Updated master profile for shorter Hazelcast shutdown #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @alparslanavci , Is this happening only for master profile? What about normal build? |
|
It is ok with the normal build, since it is running with 3.7.4 which doesn't have the changes in shutdown mechanism. |
|
Can you update it to the latest hazelcast version? |
|
@mesutcelik can you please review it? |
mesutcelik
approved these changes
Mar 14, 2019
|
verify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After Hazelcast 3.9, the shutdown mechanism affected from the improvements on mastership claim process. With the usage of context classloader, the shutdown durations take longer time on tests. A 10 secs of
hazelcast.graceful.shutdown.max.waitadded to the master profile to make the tests complete in time.