Updated the findSession method to fix concurrency issues
#61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR might bring some performance issues because of pessimistic lock usage. I will open another issue to point out this possible problem. |
|
@alparslanavci, what about entryEvicted case? With new listener, you only catch removed sessions, not evicted/expired ones. |
|
@gokhanoner yes, I missed that part. Thanks for pointing out. I added them. |
mesutcelik
approved these changes
Mar 18, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42 & #34
Hazelcast calls in
HazelcastSessionManager.findSession(id)method (removeandset) should be concurrent in order to provide thread-safe access to the session object.The depreciated usage of
EntryListeneris also replaced withMapListener.