Upgrade to jakarta namespace #140
Conversation
There was a problem hiding this comment.
@orcunc Hold on a second, there's a release in progress for this so we can't merge anything. The customer wanted a release with the old javax namespace, also do you have a jira issue for this change? I'm already working on this project, and as I know there's no jakarta release planned
pom.xml
Outdated
| <jsp.api.version>4.0.0-M2</jsp.api.version> | ||
| <servlet.api.version>6.1.0-M2</servlet.api.version> |
There was a problem hiding this comment.
what's M2 in the version?
M2 was the latest version at the time PR is created. Now new versions have been released.
rev : efd7ad2
There was a problem hiding this comment.
should we update
hazelcast-wm/checkstyle/checkstyle.xml
Line 132 in 3037ef7
The rule is for javax.swing |
|
|
||
| - Target application or web server should support Servlet 4.0 or higher spec. Note that this library supports, "javax" namespace, not the new "jakarta" one. | ||
| - Target application or web server should support Servlet 6.1 or higher spec. Note that this library supports, "jakarta" namespace. |
There was a problem hiding this comment.
Nit - if it exclusively supports jakarta, it should explain it doesn't support javax (and perhaps reference the last version that did).
There was a problem hiding this comment.
Hmm, should not we support tomcat 10 (a currently supported version
) as well? Tomcat 10 supports servlet 6.0 and java 11 and higher.
There was a problem hiding this comment.
We are saying that we support Servlet 6.1. Servlet 6.1 can be implemented by tomcat, jetty or any other servlet container.
| @@ -653,7 +657,7 @@ | |||
| </profile> | |||
| <profile> | |||
| <!-- SUP-420 case. Tomcat 9.0.z and 5.3.z hazelcast. Using jdk 1.8 because tomcat supports 1.8. | |||
| Therefore we have to exclude jetty tests from compiling/running and jetty classes from classpath | |||
| Therefore, we have to exclude jetty tests from compiling/running and jetty classes from classpath | |||
| because they require jdk 11. --> | |||
| <id>tomcat-jdk8</id> | |||
There was a problem hiding this comment.
this may not be working anymore, I think we should change a lot of dependency versions in this profile. we can even remove this profile, because tomcat 9 is not supported by this version of hazelcast-wm
There was a problem hiding this comment.
We can remove it later. This module needs more work. Let's first upgrade to jakarta. Then we can remove these kind of things later
diff --git a/README.md b/README.md
index d3e7406..de6fa7c 100644
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@
<br></br>
*You can also check [Hazelcast Guides: Session Replication with Spring Boot and Hazelcast](https://guides.hazelcast.org/springboot-webfilter-session-replication/).*
-***Note***: *Hazelcast 5.0+ is compatible with Hazelcast-WM 5.0. For older Hazelcast versions, use the latest Hazelcast-WM 3.x.x or 4.x.x releases.*
+***Note***: *Hazelcast 5.0+ is compatible with Hazelcast-WM 5.0+. For older Hazelcast versions, use the latest Hazelcast-WM 3.x.x or 4.x.x releases.*
<br></br>
Assume that you have more than one web server (A, B, C) with a load balancer in front of it. If server A goes down, your users on that server will be directed to one of the live servers (B or C), but their sessions will be lost.
|
|
verify |
This project is kind of abandoned. It has not been release for long time.
The purpose of this PR is to upgrade spring and jakarta dependencies so that the project can be useful again.